Do not make changes to core code (anything in DynmapCore or DynmapCoreAPI) unless you're ready to build and test it on all supported platforms.The code needs to be 'prettied up', it'll be done by the Dynmap team. This makes the PR excessively large,Ĭreating changes to be reviewed that don't actually do anything (but we have to review them to be sure they aren't being used to disguise securityĬompromises or other malicious code), and they create problems with the MANY people who fork Dynmap for the sake of doing PRs or their own privateĬustom builds - since all theose modified lines create merge conflicts - once again, with no actual function having been accomplished. Do not make style changes, reflow code, pretty printing, or otherwise make formatting-only code changes.Do not lump multiple features into one PR - you'll be asked to split them up before they will be reviewed or accepted. All PRs should be as small as they can be to accomplish the feature or fix being supplied.Ultimately, we reserve the right to accept or deny a PR for any reason: fact is, by accepting it, we're also accepting any of the problems with supporting it,Įxplaining it to users, and fixing current and future problems - if we don't think the PR is of value consistent with that cost, we'll probably not accept it.The Dynmap team welcomes Pull Requests with fixes, new features, and new platform support. Additionally, injecting driver classes into jar file will be recognized and supported. For Forge and Fabric servers we recommend Kosma's SQLite mod or MySQL mod to add the needed drivers.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |